Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include percentiles in the pausetimes bench data #450

Closed
punchagan opened this issue May 24, 2023 · 2 comments
Closed

Include percentiles in the pausetimes bench data #450

punchagan opened this issue May 24, 2023 · 2 comments

Comments

@punchagan
Copy link
Contributor

The current format of the output hard depends on the exact order which olly uses, which may change and the data will become useless. The distribution should be a map not an array.

https://github.com/ocaml-bench/sandmark-nightly/blob/main/pausetimes_seq/turing/20230523_083948/a6f309fee5f78adcf0d2d748aebd12a53fe53d21/5.2.0%2Btrunk%2Bbartoszmodelski%2Bpr12212%2Bpausetimes_seq_1.pausetimes.summary.bench#L31-L50

For reference, here's where the percentiles come from: https://github.com/tarides/runtime_events_tools/blob/main/bin/olly.ml#L25-L43

@punchagan
Copy link
Contributor Author

punchagan commented May 24, 2023

The JSON is directly generated by passing the --json flag to the olly latency command. The JSON produced by olly latency needs to be fixed. See here

@punchagan
Copy link
Contributor Author

The issue has been fixed in tarides/runtime_events_tools#13 but runtime_events_tools doesn't install on OCaml 5.1 and 5.2 due to ppxlib dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant