Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports
obus.ppx
from OMP to ppxlib. As discussed here, the next major release of OMP will drop significant parts of its API including the driver and Ast_mapper.I did the naive port using
Ast_traverse
to keep this simple but I have the feeling this could be turned into a deriving ppx.Maybe with a few changes to ppxlib we wouldn't even have to break the ppx's API and could keep the
[@@obus ...]
syntax. Rewriting as such would improve performances whenobus.ppx
is combined with other PPXes.You'll note that I bumped the minimum requirement for dune. That is due to the fact the 2.0 menhir extension is only available from dune 1.4 forward.