Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ppx from omp to ppxlib #25

Merged
merged 1 commit into from Aug 22, 2020

Conversation

NathanReb
Copy link
Contributor

This PR ports obus.ppx from OMP to ppxlib. As discussed here, the next major release of OMP will drop significant parts of its API including the driver and Ast_mapper.

I did the naive port using Ast_traverse to keep this simple but I have the feeling this could be turned into a deriving ppx.
Maybe with a few changes to ppxlib we wouldn't even have to break the ppx's API and could keep the [@@obus ...] syntax. Rewriting as such would improve performances when obus.ppx is combined with other PPXes.

You'll note that I bumped the minimum requirement for dune. That is due to the fact the 2.0 menhir extension is only available from dune 1.4 forward.

@meadofpoetry
Copy link
Collaborator

Thanks.

I did the naive port using Ast_traverse to keep this simple but I have the feeling this could be turned into a deriving ppx.

Well, I'm planning to remove ppx in 2.0 (it seems like nobody uses it, at least no one has said they do), so one could write a totally new ppx for obus as a standalone library, e.g. as a ppx_deriving plugin.

@meadofpoetry meadofpoetry merged commit 8d38ee6 into ocaml-community:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants