Correct paths for utop-history, utoprc: in utop subdirs of XDG base dirs #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added check & creation of history file's parent directory, fixing #478 This was exacerbated with the first patch because XDG_STATE_HOME/utop was extremely unlikely to exist on any system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #481 described failure to load utoprc from its stated location
PR #475 misidentified the issue as an incorrect README
In fact the paths were pointing to files within the XDG base directories themselves rather than in a subdirectory for the utop application.
This patch simply changes $XDG_STATE_HOME/utop-history to $XDG_STATE_HOME/utop/utop-history and $XDG_CONFIG_HOME/utoprc to $XDG_CONFIG_HOME/utop/utoprc