Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caml_get_header to runtime5 #2035

Closed
wants to merge 1 commit into from

Conversation

riaqn
Copy link
Contributor

@riaqn riaqn commented Nov 15, 2023

Forward port the runtime part of ocaml-flambda/ocaml-jst@5be3cb8

Note that as of now, runtime5 doesn't have stack allocation, so lib-obj/get_header.ml will fail as some object are on heap (while expected to be on stack)

@mshinwell
Copy link
Collaborator

@riaqn can you fix the test case so that it passes when stack allocation is disabled too? There are some examples in typing-local/ as to how to do this, using the stack-allocation ocamltest predicate.

@riaqn
Copy link
Contributor Author

riaqn commented Nov 16, 2023

I suggest postpone this PR until proper local allocation is supported in runtime; because currently is_stack cannot be defined, becuase I don't know what would be the color for stack objects. And is_stack is a major motivation for get_header.

@riaqn riaqn marked this pull request as draft November 17, 2023 15:28
@mshinwell mshinwell deleted the branch ocaml-flambda:runtime5-features November 20, 2023 10:06
@mshinwell mshinwell closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants