Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate back edges #2722

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Deduplicate back edges #2722

merged 1 commit into from
Jul 4, 2024

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Jun 25, 2024

It does not really make a difference right now,
but I don't think there are any reasons to have
duplicates in the collection of back edges.

This pull request thus simply changes this
collection from Edge.t to EdgeSet.t.

Copy link
Collaborator

@mshinwell mshinwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but it might be nice in the future to change to e.g. Edge.Set.t.

@mshinwell mshinwell merged commit 7c89a7c into main Jul 4, 2024
18 checks passed
@mshinwell mshinwell deleted the dedup-back-edges branch July 4, 2024 14:38
Ekdohibs pushed a commit to Ekdohibs/flambda-backend that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants