Fix inclusion checks for primitives #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but it would be good to avoid the code duplication in |
lpw25
force-pushed
the
fix-primitive-moregen
branch
from
dc05d32
to
7f09ad6
Compare
|
Closing in favour of ocaml-flambda/flambda-backend#661 |
antalsz
pushed a commit
to antalsz/ocaml-jst
that referenced
this pull request
Mar 29, 2023
…a#23) * Local allocation support for arrays and records * Relax the Max_young_wosize constraint on local allocs * Runtime support for local array allocations. Includes a bugfix in realloc_local (wsize/bsize confusion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion check implementation for primitives assumed that moregen forced modes to be equal, which is no longer the case. Replace it with an implementation that just checks both possible types.