Add support for custom ghost type as model #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shym
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM, thanks!
Just a tiny comment:
- 90034f5 Factorize logic of core_type_of_ty
The modification to the .mli should be in the previous commit.
Maybe the auxiliary common function could be calledcore_type_of_ty_auxorcore_type_of_ty_commoninstead of_core_type_of_ty?
Adapted from core_type_of_ty_with_subst
Constructors with record as argument are not supported yet, as they are buggy in Gospel.
This commit proposes a naive implementation, no checks are done on the constructors name for example.
n-osborne
force-pushed
the
support-custom-ghost-types
branch
from
b81c394
to
e6a2e74
Compare
|
CI failure is unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an answer to #209 by adding a translation for
type_declarations in ortac-core and use it in ortac-qcheck-stm.The translation doesn't support constructors with inlined records, as they are buggy in Gospel anyway and it is still an open question whether they will be fixed or removed there.
The use of translated gospel types in ortac-qcheck-stm is naive: the symbols for constructors or record fields as translated are they appears in the gospel ast and are not stored in the context (as it is the case for gospel functions).