Remove closure allocation in Chan #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctk21
force-pushed
the
ctk21/remove_closure_allocation_chan
branch
from
cfc8c8f
to
e45a7aa
Compare
|
(rebased to pick up #30 for the CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unnecessary closure allocation in
recv'andsend'by factoring out theloopfunction in each and makingrecv'/send'recursive . It also adds a simpletask_throughputtest program which is quick and easy to see the impact of task changes.For
OCAMLRUNPARAM=v=0x400 task_throughput.exe 4, I see:allocated_words: 3017378allocated_words: 2725132