Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buf_write: Fix BE.uint48 and LE.uint48. #418

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Buf_write: Fix BE.uint48 and LE.uint48. #418

merged 2 commits into from
Jan 31, 2023

Commits on Jan 30, 2023

  1. Add Eio.Buf_read.uint8 

    This is to match `Buf_write.uint8`.
    @talex5
    talex5 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3a6dea8 View commit details
    Browse the repository at this point in the history

  2. Buf_write: Fix BE.uint48 and LE.uint48. 

    Arguments to logical shift are provided in bits, not bytes.
Also, the BE version mixed up the 32-bit and 16-bit sizes.
Note: this bug also affects Faraday.

Co-authored-by: Thomas Leonard <talex5@gmail.com>
    @adatario @talex5
    adatario and talex5 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    931be24 View commit details
    Browse the repository at this point in the history