Fix various architectures #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCaml ints are on bit shorter than C ints.
Dune has various other odd names for Linux: ocaml/dune#4895
|
|
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Feb 5, 2023
CHANGES: Some build fixes: - Fix build on various architectures (@talex5 ocaml-multicore/eio#432). - Work around dune `%{system}` bug. - eio_luv: fix `max_luv_buffer_size` on 32-bit platforms. - Add missing test-dependency on MDX (@talex5 ocaml-multicore/eio#430).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Feb 5, 2023
CHANGES: Some build fixes: - Fix build on various architectures (@talex5 ocaml-multicore/eio#432). - Work around dune `%{system}` bug. - eio_luv: fix `max_luv_buffer_size` on 32-bit platforms. - Add missing test-dependency on MDX (@talex5 ocaml-multicore/eio#430).
This was referenced Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune has various other odd names for Linux on different architectures: ocaml/dune#4895
Note: I didn't do this for the tests. We'll still run the main test suite on these platforms.
Also, we defined
max_luv_buffer_size = 0x7fffffff, but this doesn't work on 32-bit systems. Surprisingly, it doesn't trigger theInteger literal exceeds the range of representable integers of type interror either.Something similar happens on 64-bits systems too:
And this is pretty odd too:
Apparently this isn't considered a bug: ocaml/ocaml#4245