Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require MDX < 2.4.0 #706

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Require MDX < 2.4.0 #706

merged 1 commit into from
Feb 29, 2024

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented Feb 29, 2024

The MDX devs have decided to change the behaviour of includes. What was previously a request to copy some text from one file to another now, in mdx 2.4.0, will also execute it!!

See realworldocaml/mdx#446

The new version attempts to execute included blocks, and also seems
broken on macos.
@talex5 talex5 changed the title Update for MDX 2.4.0 Require MDX < 2.4.0 Feb 29, 2024
@talex5
Copy link
Collaborator Author

talex5 commented Feb 29, 2024

Hmm, that failed on macos for some reason:

Fatal error: exception Mdx_test.Test_block_failure(_, "./examples/signals/main.ml: No such file or directory")

Constrain to use the old version instead for now.

@talex5 talex5 merged commit 7b58999 into ocaml-multicore:main Feb 29, 2024
4 of 5 checks passed
@talex5 talex5 deleted the mdx-fail branch February 29, 2024 16:08
talex5 added a commit to talex5/opam-repository that referenced this pull request Mar 10, 2024
CHANGES:

New features:

- Add `Eio_unix.Cap` module to enable Capsicum mode (@talex5 ocaml-multicore/eio#697, reviewed by @SGrondin).

- eio_linux: expose more functions in the `Low_level` module (@talex5 ocaml-multicore/eio#705, reviewed by @SGrondin).
  Add all the functions used by other parts of eio_linux (`openat`, `mkdir`, `read_link`, `unlink`, `rename` and `pipe`).
  Tidied the API up a bit too:
  - `mkdir_beneath` is now just `mkdir`.
  - `statx_confined` is now just `statx`.
  - `open_dir` is gone; the single user now calls `openat` directly.

Documentation:

- Add README documentation for `Eio.Executor_pool` (@SGrondin @talex5 ocaml-multicore/eio#707, reviewed by @Sudha247).

- eio_linux: remove logging (@talex5 ocaml-multicore/eio#708, requested by @clecat).
  There were only two remaining uses of Logs, neither of which has proved useful.

Build:

- Add upper-bound on MDX (@talex5 ocaml-multicore/eio#706).
  The new version attempts to execute included blocks.

- Fix tests to pass with both old and new Kcas (@polytypic ocaml-multicore/eio#704).

- Make posix `open_beneath` test idempotent (@SGrondin ocaml-multicore/eio#703).

- Executor_pool: mention requested weight in error message (@talex5 ocaml-multicore/eio#702, reported by @yawaramin).
talex5 added a commit to talex5/opam-repository that referenced this pull request Mar 10, 2024
CHANGES:

New features:

- Add `Eio_unix.Cap` module to enable Capsicum mode (@talex5 ocaml-multicore/eio#697, reviewed by @SGrondin).

- eio_linux: expose more functions in the `Low_level` module (@talex5 ocaml-multicore/eio#705, reviewed by @SGrondin).
  Add all the functions used by other parts of eio_linux (`openat`, `mkdir`, `read_link`, `unlink`, `rename` and `pipe`).
  Tidied the API up a bit too:
  - `mkdir_beneath` is now just `mkdir`.
  - `statx_confined` is now just `statx`.
  - `open_dir` is gone; the single user now calls `openat` directly.

Documentation:

- Add README documentation for `Eio.Executor_pool` (@SGrondin @talex5 ocaml-multicore/eio#707, reviewed by @Sudha247).

- eio_linux: remove logging (@talex5 ocaml-multicore/eio#708, requested by @clecat).
  There were only two remaining uses of Logs, neither of which has proved useful.

Build:

- Add upper-bound on MDX (@talex5 ocaml-multicore/eio#706).
  The new version attempts to execute included blocks.

- Fix tests to pass with both old and new Kcas (@polytypic ocaml-multicore/eio#704).

- Make posix `open_beneath` test idempotent (@SGrondin ocaml-multicore/eio#703).

- Executor_pool: mention requested weight in error message (@talex5 ocaml-multicore/eio#702, reported by @yawaramin).
talex5 added a commit to talex5/opam-repository that referenced this pull request Mar 10, 2024
CHANGES:

New features:

- Add `Eio_unix.Cap` module to enable Capsicum mode (@talex5 ocaml-multicore/eio#697, reviewed by @SGrondin).

- eio_linux: expose more functions in the `Low_level` module (@talex5 ocaml-multicore/eio#705, reviewed by @SGrondin).
  Add all the functions used by other parts of eio_linux (`openat`, `mkdir`, `read_link`, `unlink`, `rename` and `pipe`).
  Tidied the API up a bit too:
  - `mkdir_beneath` is now just `mkdir`.
  - `statx_confined` is now just `statx`.
  - `open_dir` is gone; the single user now calls `openat` directly.

Documentation:

- Add README documentation for `Eio.Executor_pool` (@SGrondin @talex5 ocaml-multicore/eio#707, reviewed by @Sudha247).

- eio_linux: remove logging (@talex5 ocaml-multicore/eio#708, requested by @clecat).
  There were only two remaining uses of Logs, neither of which has proved useful.

Build:

- Add upper-bound on MDX (@talex5 ocaml-multicore/eio#706).
  The new version attempts to execute included blocks.

- Fix tests to pass with both old and new Kcas (@polytypic ocaml-multicore/eio#704).

- Make posix `open_beneath` test idempotent (@SGrondin ocaml-multicore/eio#703).

- Executor_pool: mention requested weight in error message (@talex5 ocaml-multicore/eio#702, reported by @yawaramin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant