Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 4.12.0+domains effects implementation(syntax-free effects version) #82

Merged
merged 9 commits into from Oct 11, 2021

Conversation

bikallem
Copy link
Contributor

@bikallem bikallem commented Oct 8, 2021

This PR updates eio to the OCaml 5.0 supported effects implementation. The migration strategy used is a mechanical one, i.e. effect -> type _ eff += .., match .. with effect .. to match_with.

Note: The PR replicates (1to1) both passing and failing tests in the repo.

Edit: Not strictly necessary but this PR(https://github.com/ocaml-multicore/ocaml-uring/pulls) is needed to make dune b happy since ocaml-uring is a git submodule of this repo.

@talex5
Copy link
Collaborator

talex5 commented Oct 9, 2021

Thanks - this allows us to enable CI on this repo at last! But the opam metadata needs updating:

- eio_linux -> (problem)
    Rejected candidates:
      eio_linux.dev: Requires ocaml-variants = 4.12.0+domains+effects

@bikallem
Copy link
Contributor Author

@talex5 looks like we need a .ocamlformat file for the ci to pass. Should I add it? and set the profile to conventional ?

Edit: CI failure -> https://ci.ocamllabs.io/github/ocaml-multicore/eio/commit/95cdeafce2dff6f99d6ffdefdaba61fef7ae59c0/variant/(lint-fmt)

Copy link
Collaborator

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've pushed a few more fixes to your branch. Should be good to merge once CI is finished.

@talex5 talex5 merged commit 1cf6706 into ocaml-multicore:main Oct 11, 2021
@bikallem bikallem deleted the 4.12.0+domains branch October 11, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants