Disable the negative Out_channel tests on Windows and macOS #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are not triggering consistently on those platforms so we disable them for now
Reducing the noise would indeed be very welcome!
I was wondering about that myself! Is there a particular shape triggering these failures on macOS and Windows, e.g., if one compares the failures (once they fail)? If we could have them trigger more consistently, that would also prevent them from completing and hence speed them up... 馃 |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are not triggering consistently on those platforms (and often take a lot of time) so this PR proposes to disable them at least for now, to reduce the noise of CI failures.
Maybe the frequencies could be tweaked so that they trigger most consistently? 馃