Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rep_count in STM_thread #316

Merged
merged 2 commits into from Apr 13, 2023
Merged

Fix rep_count in STM_thread #316

merged 2 commits into from Apr 13, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 23, 2023

I accidentally discovered that the two rep_counts in STM_thread were different:

  • agree_test_conc would perform 100 repetitions whereas
  • neg_agree_test_conc would perform only 25 repetitions

I think this is simply a copy-paste error.

I wonder whether this would allow us to trigger STM_thread test errors more consistently... 馃

@jmid
Copy link
Collaborator Author

jmid commented Mar 28, 2023

Rebased on main and added a CHANGES entry

@jmid
Copy link
Collaborator Author

jmid commented Apr 13, 2023

CI summary:

  • The Out_channel test failed to trigger on Windows bytecode and macOS trunk
    • it also took 9440.3s on macOS causing a time out and appears to cause a timeout on macOS trunk
  • Cygwin trunk part 1 timed out with a number of different tests taking a bit long
  • Lin DSL Weak HashSet test took an extraordinary 14177.8s to shrink on Windows bytecode 5.0.0 and 9009.0s on Cygwin trunk part 2 both causing a timeouts
  • threadomain dead locked on Windows trunk

None of these are related to this PR so I'll merge.

@jmid jmid merged commit 0e91262 into main Apr 13, 2023
24 of 32 checks passed
@jmid jmid deleted the fix-STM_thread-rep_count branch April 13, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant