Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make qcheck-lin and qcheck-stm available on OCaml 4.x #329

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Make qcheck-lin and qcheck-stm available on OCaml 4.x #329

merged 4 commits into from
Apr 26, 2023

Commits on Apr 18, 2023

  1. Make qcheck-lin and qcheck-stm available on OCaml 4.x 

    Their Thread mode is useful for testing OCaml 4.x code too.

Unfortunately 'enabled_if' in  'test' stanza in dune doesn't work: it still
attempts to build it, which would fail on OCaml 4, so have to use separate
executable/runtest alias where 'enabled_if' works properly.

The following now compiles:
```
dune build -p qcheck-multicoretests-util,qcheck-stm,qcheck-lin
```

The tests run, but the output is currently different from OCaml 5:
```
dune runtest -p qcheck-multicoretests-util,qcheck-stm,qcheck-lin
```

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
    @edwintorok
    edwintorok committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    672a494 View commit details
    Browse the repository at this point in the history

  2. test: add OCaml 4 versions of expected output 

    It uses a different RNG.

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
    @edwintorok
    edwintorok committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5854e7d View commit details
    Browse the repository at this point in the history

  3. opam: Require OCaml 4.14 for qcheck-lin 

    It uses some new functions from Seq.

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
    @edwintorok
    edwintorok committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7ba5aaa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Add a CHANGES entry

    @jmid
    jmid committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    04df34f View commit details
    Browse the repository at this point in the history