Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: src/neg_tests cleanups #330

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Chore: src/neg_tests cleanups #330

merged 2 commits into from
Apr 19, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Apr 18, 2023

While trying out #329 on selected parts of the test suite locally I discovered a couple of needless dependencies in src/neg_tests. This PR seeks to remove them:

  • Our src/neg_tests/lin Thread tests depended on lin_common* files both needlessly requiring Domains - and so we move the Lin_domain functor applications to the Domain-driver files
  • The src/neg_tests/stm_tests* had a qcheck dependency rather than requiring qcheck-core and so we switch to using QCheck_base_runner like the rest of the test suite.

@jmid
Copy link
Collaborator Author

jmid commented Apr 19, 2023

CI summary:

  • Win bytecode 5.1 failure to trigger Out_channel issue
  • Cygwin trunk part1 timeout due to excessive runtimes of multiple Lin Domain tests (BigArray1,Atomic,Bytes,Ephemeron,Out_channel)
  • Win trunk and Win bytecode 5.1 + trunk threadomain deadlocks
  • Cygwin trunk part2 failure to trigger STM int ref test parallel asymmetric
  • Cygwin 5.1 part2 timeout due to excessive runtime of two tests: Sys STM test and Lin DSL Weak HashSet test with Domain
  • Cygwin 5.1 part2 timeout due to excessive test runtime of Lin DSL Weak HashSet test with Domain incl. failure to trigger STM int64 ref test parallel asymmetric

None of these are related to this PR so I'll merge.

@jmid jmid merged commit 2759aa3 into main Apr 19, 2023
28 of 36 checks passed
@jmid jmid deleted the negtests-cleanups branch April 19, 2023 07:40
@jmid jmid mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant