Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temporary acceptance in STM Out_channel test #441

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 8, 2024

The PR

Finally I snuck in adding the Cygwin flexlink issue, to avoid having that trigger a full CI run...

@jmid jmid force-pushed the reenable-closed-outch-error-check branch from 0efb4a8 to 9b2593c Compare March 27, 2024 17:00
@jmid
Copy link
Collaborator Author

jmid commented Mar 27, 2024

This was opened too soon, causing all 5.2 workflows to fail as they were still testing 5.2.0~alpha1 without the fix.

Now that CI targets 5.2.0~beta1 with #445 I've rebased the PR.

In doing so I've removed the commit marking the Out_channel issue as fixed, as that was fixed in #442.

@jmid
Copy link
Collaborator Author

jmid commented Mar 27, 2024

CI summary:

Out of 37 workflows 4 failed, all with genuine issues

@jmid jmid merged commit 6d719d1 into main Mar 27, 2024
23 of 27 checks passed
@jmid jmid deleted the reenable-closed-outch-error-check branch March 27, 2024 21:21
@jmid
Copy link
Collaborator Author

jmid commented Mar 28, 2024

CI summary for merge to main:

Out of 38 workflows 4 failed, all with genuine issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant