Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on 5.2.0 on Windows #104

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Test on 5.2.0 on Windows #104

merged 1 commit into from
Jun 4, 2024

Conversation

polytypic
Copy link
Collaborator

No description provided.

@polytypic polytypic force-pushed the test-and-bench-on-5.2.0 branch 2 times, most recently from 1cdafac to bfdfd2a Compare April 27, 2024 15:21
@polytypic polytypic force-pushed the test-and-bench-on-5.2.0 branch 3 times, most recently from 1d63574 to 87343f8 Compare May 13, 2024 20:35
@polytypic polytypic marked this pull request as ready for review May 13, 2024 20:36
@polytypic polytypic force-pushed the test-and-bench-on-5.2.0 branch 5 times, most recently from 388c001 to ee67d44 Compare May 14, 2024 15:59
@kit-ty-kate
Copy link
Contributor

kit-ty-kate commented May 14, 2024

looks like a bug in ocaml/setup-ocaml:

  D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19591
          if (!arg.includes(" ") && !arg.includes("	") && !arg.includes('"')) {
                   ^
  
  TypeError: arg.includes is not a function
      at ToolRunner._uvQuoteCmdArg (D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19591:18)
      at ToolRunner._windowsQuoteCmdArg (D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19532:23)
      at ToolRunner._getCommandString (D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19474:31)
      at ToolRunner.<anonymous> (D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19662:51)
      at Generator.next (<anonymous>)
      at D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19428:71
      at new Promise (<anonymous>)
      at __awaiter (D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19410:14)
      at D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19654:52
      at new Promise (<anonymous>)
  
  Node.js v20.8.1

Could you open an issue upstream?

@polytypic
Copy link
Collaborator Author

looks like a bug in ocaml/setup-ocaml:

  D:\a\_actions\ocaml\setup-ocaml\v2\dist\index.cjs:19591
          if (!arg.includes(" ") && !arg.includes("	") && !arg.includes('"')) {
                   ^
  
  TypeError: arg.includes is not a function

[...]

Could you open an issue upstream?

Yes, you mean to setup-ocaml, although I have no idea what is the cause of the problem here. I'll open an issue there with a link to here.

@polytypic polytypic changed the title Test and bench on 5.2.0 Test on 5.2.0 on Windows May 18, 2024
Co-authored-by: Kate <kit-ty-kate@outlook.com>
@polytypic polytypic force-pushed the test-and-bench-on-5.2.0 branch 2 times, most recently from 93fe655 to 3c4cd84 Compare June 4, 2024 21:19
@polytypic polytypic merged commit fdf8d24 into main Jun 4, 2024
8 of 9 checks passed
@polytypic polytypic deleted the test-and-bench-on-5.2.0 branch June 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants