-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
~Travis CI~ All the CI #7
Conversation
Right, Windows fixes and more testing included as well. So, at the moment:
|
src/lp_solver.cpp
Outdated
@@ -100,10 +134,10 @@ int lp_solver::solve() { | |||
fclose(lpfile); | |||
|
|||
if (verbosity < 2) | |||
sprintf(command, "cat %s >> %s; %s %s > %s 2> /dev/null", | |||
sprintf(command, "cat %s >> %s && %s %s > %s 2> nul", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops - sorry, this shouldn't be here.
Allows having default test criteria but changing the solver (more natural).
Output isn't steady enough.
Need the (universe) dependency.
Use system call to determine temporary file location and implement Windows alternative for `getpid`. Windows temporary directories are already user-specific, so no alternate implementation of `getuid` is provided.
Although implementations of cat (and, optionally, tee) are still required.
Commenting out the lines allows Remote Desktop connection at the end of the build.
The upgrade scripts assumed Cygwin64 (copied from opam), but the CI was actually using Cygwin32. Corrected to use Cygwin64 as intended - and therefore to install the missing patch package (which was being incorrectly picked up from Git-for-Windows beforehand).
The unzip utility does not support GNU's --version, so add a -v test as well as an alternate.
Thanks!
Indeed! |
case $TRAVIS_OS_NAME in | ||
linux) | ||
sudo apt-get install coinor-libclp-dev coinor-libcbc-dev coinor-libsymphony-dev mccs | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't that rather be in .travis.yml
addons.apt.packages section ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be, but Travis seem to have taken their linter offline while they develop a new one and I could not be bothered to figure out the expansion of the matrix so that the addons only applied to Linux, and not macOS. It's also the case that once the backend testing is extended to macOS that it has to be done using commands rather than YAML changes, because you need a different homebrew tap. So it seemed better to do all the package installations by hand.
It'd be fine if YAML weren't such a arm-gnawingly useless way of specifying anything...
Enables Travis CI with compilation of the new backends (I have WIP for testing using the alternate backends as well, but it needs some further testing)