Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.00.0 and 5.00.0 compatibility... #147

Merged
merged 1 commit into from
Jan 21, 2022
Merged

4.00.0 and 5.00.0 compatibility... #147

merged 1 commit into from
Jan 21, 2022

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jan 20, 2022

Slightly hideous, but at least then we don't end up with multiple versions ever installing across switches - this should "work" with both compilation modes.

Tested on 4.00.1 and 5.00.0

@dbuenzli
Copy link
Contributor

Did you see #146 ?

@dra27
Copy link
Member Author

dra27 commented Jan 20, 2022

I did - the point here is keeping 4.02 support (alas)

Copy link
Contributor

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the missing uppercase Y/N.

(I don’t have the rights on this repo so I can’t merge it or apply the suggestion)

depext.ml Outdated Show resolved Hide resolved
@dra27 dra27 merged commit 7c13292 into ocaml-opam:2.0 Jan 21, 2022
@dra27 dra27 mentioned this pull request Jan 21, 2022
dra27 added a commit to dra27/opam-depext that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants