Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from JBuilder to Dune and document building and testing instructions #85

Merged
merged 1 commit into from Dec 11, 2018
Merged

Upgrade from JBuilder to Dune and document building and testing instructions #85

merged 1 commit into from Dec 11, 2018

Conversation

anmonteiro
Copy link
Contributor

No description provided.

@anmonteiro anmonteiro mentioned this pull request Dec 11, 2018
Closed
@gasche
Copy link
Contributor

gasche commented Dec 11, 2018

(When I saw the PR title I didn't get it, as we have migrate to dune already. The point is to move from "jbuilder" to "dune", so rather an upgrade than yet another build system change.)

@anmonteiro
Copy link
Contributor Author

(When I saw the PR title I didn't get it, as we have migrate to dune already. The point is to move from "jbuilder" to "dune", so rather an upgrade than yet another build system change.)

That's correct. I'll update the title accordingly once I squash my commits.

@gasche
Copy link
Contributor

gasche commented Dec 11, 2018

(There is some discussion of this PR at #83 (comment) )

Again: thanks a lot, this is great. You offered to create Changelog entries as well (feel free to say if this is too much work); let me know if/when this is ready, and I'll finish the release.

@anmonteiro
Copy link
Contributor Author

@gasche I added a commit adding the CHANGELOG entries just now, but I tagged it as Unreleased. Should I change to 3.2 instead?

gasche
gasche reviewed Dec 11, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
gasche
gasche reviewed Dec 11, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@gasche
Copy link
Contributor

gasche commented Dec 11, 2018

This should be good to go. (After I merge, I will update the Changelog to use people's Real Name when they have a preferred one, instead of github handles.) You seem to be thinking of rebasing to squash commits, let me know when you agree this is ready for merging.

@anmonteiro
Upgrade from JBuilder to Dune and document building and testing instr…
1c82f34 
…uctions

This also updates the CHANGELOG for a release.
@anmonteiro anmonteiro changed the title [WIP] Migrate to Dune and document building and testing instructions Upgrade from JBuilder to Dune and document building and testing instructions Dec 11, 2018
@anmonteiro
Copy link
Contributor Author

@gasche Done! Thanks for your review.

@gasche gasche merged commit acde30c into ocaml-ppx:master Dec 11, 2018
gasche added a commit to gasche/opam-repository that referenced this pull request Dec 15, 2018
@gasche
ppx_deriving_yojson.3.3
815e59c 
(3.2 broke backward-compatibility so it was not released)

3.3
---

  * Make `_exn` functions opt-in (`[@@deriving yojson { exn = true }]`)
    to preserve backward-compatibility for fully-manual implementations
    of the [@@deriving yojson] interface.
    (ocaml-ppx/ppx_deriving_yojson#86)
    Gabriel Scherer

3.2
---

  * Add `let _ = to_yojson / of_yojson` to generated code to avoid warnings when
    they aren't used
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Fix bug where doing [@@deriving of_yojson] causes an unused rec warning
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Add generated `ty_of_yojson_exn` to raise an exception rather than return an
    error
    (ocaml-ppx/ppx_deriving_yojson#57, ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Port `ppx_deriving_yojson` to `dune`
    (ocaml-ppx/ppx_deriving_yojson#69, ocaml-ppx/ppx_deriving_yojson#85)
    Rudi Grinberg, Antonio Nuno Monteiro
  * Added deriver option `fields` to generate a `Yojson_meta` module containing
    all JSON key names.
    (ocaml-ppx/ppx_deriving_yojson#70)
    Steve Bleazard
  * Remove cppo that included support for versions no longer supported by
    `ppx_deriving_yojson`
    (ocaml-ppx/ppx_deriving_yojson#75)
    Rudi Grinberg
@gasche gasche mentioned this pull request Dec 15, 2018
Merged
mseri pushed a commit to ocaml/opam-repository that referenced this pull request Dec 16, 2018
@gasche @mseri
ppx_deriving_yojson.3.3 (#13150)
ec795aa 
(3.2 broke backward-compatibility so it was not released)

3.3
---

  * Make `_exn` functions opt-in (`[@@deriving yojson { exn = true }]`)
    to preserve backward-compatibility for fully-manual implementations
    of the [@@deriving yojson] interface.
    (ocaml-ppx/ppx_deriving_yojson#86)
    Gabriel Scherer

3.2
---

  * Add `let _ = to_yojson / of_yojson` to generated code to avoid warnings when
    they aren't used
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Fix bug where doing [@@deriving of_yojson] causes an unused rec warning
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Add generated `ty_of_yojson_exn` to raise an exception rather than return an
    error
    (ocaml-ppx/ppx_deriving_yojson#57, ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Port `ppx_deriving_yojson` to `dune`
    (ocaml-ppx/ppx_deriving_yojson#69, ocaml-ppx/ppx_deriving_yojson#85)
    Rudi Grinberg, Antonio Nuno Monteiro
  * Added deriver option `fields` to generate a `Yojson_meta` module containing
    all JSON key names.
    (ocaml-ppx/ppx_deriving_yojson#70)
    Steve Bleazard
  * Remove cppo that included support for versions no longer supported by
    `ppx_deriving_yojson`
    (ocaml-ppx/ppx_deriving_yojson#75)
    Rudi Grinberg
fdopen added a commit to fdopen/opam-repository-mingw that referenced this pull request Dec 18, 2018
@fdopen
ppx_deriving_yojson.3.3 (#13150)
913e758 
(3.2 broke backward-compatibility so it was not released)

3.3
---

  * Make `_exn` functions opt-in (`[@@deriving yojson { exn = true }]`)
    to preserve backward-compatibility for fully-manual implementations
    of the [@@deriving yojson] interface.
    (ocaml-ppx/ppx_deriving_yojson#86)
    Gabriel Scherer

3.2
---

  * Add `let _ = to_yojson / of_yojson` to generated code to avoid warnings when
    they aren't used
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Fix bug where doing [@@deriving of_yojson] causes an unused rec warning
    (ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Add generated `ty_of_yojson_exn` to raise an exception rather than return an
    error
    (ocaml-ppx/ppx_deriving_yojson#57, ocaml-ppx/ppx_deriving_yojson#68)
    Steve Bleazard
  * Port `ppx_deriving_yojson` to `dune`
    (ocaml-ppx/ppx_deriving_yojson#69, ocaml-ppx/ppx_deriving_yojson#85)
    Rudi Grinberg, Antonio Nuno Monteiro
  * Added deriver option `fields` to generate a `Yojson_meta` module containing
    all JSON key names.
    (ocaml-ppx/ppx_deriving_yojson#70)
    Steve Bleazard
  * Remove cppo that included support for versions no longer supported by
    `ppx_deriving_yojson`
    (ocaml-ppx/ppx_deriving_yojson#75)
    Rudi Grinberg
@gasche gasche mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasche gasche gasche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @gasche