Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ast_pattern: augment API with ebool, pbool helper, and a new map. #402

Merged
merged 9 commits into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
unreleased
------------------

- Ast_pattern now has ebool, pbool helper, and a new map.(#402, @burnleydev1)

- multiple errors are now reported in `metaquot`. (#397, @burnleydev1)

- Add `Attribute.declare_with_attr_loc` (#396, @dvulakh)
Expand Down
13 changes: 13 additions & 0 deletions src/ast_pattern.ml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ let int64 v = cst ~to_string:Int64.to_string v
let nativeint v = cst ~to_string:Nativeint.to_string v
let bool v = cst ~to_string:Bool.to_string v

let bool' (T func) =
T
(fun ctx loc x k ->
match x with
| "true" -> func ctx loc true k
| "false" -> func ctx loc false k
| _ -> fail loc "Bool")

let false_ =
T
(fun ctx loc x k ->
Expand Down Expand Up @@ -175,6 +183,9 @@ let map1' (T func) ~f =
let map2' (T func) ~f =
T (fun ctx loc x k -> func ctx loc x (fun a b -> k (f loc a b)))

let map_value (T func) ~f = T (fun ctx loc x k -> func ctx loc (f x) k)
let map_value' (T func) ~f = T (fun ctx loc x k -> func ctx loc (f loc x) k)

let alt_option some none =
alt (map1 some ~f:(fun x -> Some x)) (map0 none ~f:None)

Expand Down Expand Up @@ -221,6 +232,8 @@ let pint64 t = ppat_constant (const_int64 t)
let pnativeint t = ppat_constant (const_nativeint t)
let single_expr_payload t = pstr (pstr_eval t nil ^:: nil)
let no_label t = cst Asttypes.Nolabel ~to_string:(fun _ -> "Nolabel") ** t
let ebool t = pexp_construct (lident (bool' t)) none
let pbool t = ppat_construct (lident (bool' t)) none

let extension (T f1) (T f2) =
T
Expand Down
4 changes: 4 additions & 0 deletions src/ast_pattern.mli
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ val map2' :
f:(Location.t -> 'v1 -> 'v2 -> 'v) ->
('a, 'v -> 'b, 'c) t

val map_value : ('a, 'b, 'c) t -> f:('d -> 'a) -> ('d, 'b, 'c) t
val map_value' : ('a, 'b, 'c) t -> f:(location -> 'd -> 'a) -> ('d, 'b, 'c) t
val nil : (_ list, 'a, 'a) t
val ( ^:: ) : ('a, 'b, 'c) t -> ('a list, 'c, 'd) t -> ('a list, 'b, 'd) t
val many : ('a, 'b -> 'c, 'c) t -> ('a list, 'b list -> 'c, 'c) t
Expand All @@ -129,6 +131,8 @@ val int32 : int32 -> (int32, 'a, 'a) t
val int64 : int64 -> (int64, 'a, 'a) t
val nativeint : nativeint -> (nativeint, 'a, 'a) t
val bool : bool -> (bool, 'a, 'a) t
val ebool : (bool, 'a, 'b) t -> (expression, 'a, 'b) t
val pbool : (bool, 'a, 'b) t -> (pattern, 'a, 'b) t

val cst :
to_string:('a -> string) -> ?equal:('a -> 'a -> bool) -> 'a -> ('a, 'b, 'b) t
Expand Down