Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OCamlformat to 0.26.1 #455

Merged
merged 2 commits into from Feb 1, 2024

Conversation

Julow
Copy link

@Julow Julow commented Sep 12, 2023

The aim of this preview is to gather feedback.

This is a bug-fix release and is compatible with the slightly changed let-binding syntax in OCaml 5.1.
Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

The upgrade to OCamlformat 0.26.0 is made in a separate commit to easily check the regression. I can squash the commits if needed.

@Julow Julow changed the title Preview ocamlformat 0.26.1 Upgrade OCamlformat to 0.26.1 Sep 26, 2023
@Julow
Copy link
Author

Julow commented Sep 26, 2023

OCamlformat has been released a week ago, this is ready to be merged. If possible not squashed for the .git-blame-ignore-revs.

@pitag-ha
Copy link
Member

Thanks @Julow. We'll merge a few PRs first to avoid having them rebase.

@hhugo
Copy link
Collaborator

hhugo commented Dec 3, 2023

Thanks @Julow. We'll merge a few PRs first to avoid having them rebase.

https://github.com/hhugo/merge-fmt should help rebasing PR across reformatting commit.

@Julow Julow force-pushed the preview-ocamlformat-0.26.1 branch 3 times, most recently from 299351a to 27a0b56 Compare December 4, 2023 10:14
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Feb 1, 2024
@NathanReb
Copy link
Collaborator

Just updated this!

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NathanReb NathanReb merged commit 6da73c1 into ocaml-ppx:main Feb 1, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants