Skip to content

Dev meeting 19 04 2023

Jump to bottom
Sonja Heinze edited this page Jun 22, 2023 · 1 revision

Agenda

  • 5.1.0~alpha support
    • now: adding new migrations
    • future: bumping the AST
  • trunk support
    • separate branch? or main?
  • "recent" past work
    • documentation
    • error reporting
    • stability
  • ppxlib maintenance situation
    • time consumed by ppxlib maintenance

Present

  • Sonja
  • Paul-Elliot

Notes

5.1.0~alpha support

  • Paul-Elliot has fixed the migration bugs
  • once compiler fix is merged, we do the last adaption and the last problem should be solved
  • no tests yet
    • whenever there are parsing changes, we should add tests for the syntax corresponding to the changed parsing

Action points:

  • merge the fix tests and old compiler support PR
  • wait for the compiler merge
  • Sonja needs to review
  • we also ask Ochtachron to have a look
  • once it's merged, we need to merge it also into main and release it

trunk support

Idea: add the trunk support to main itself

  • upside:
    • we don't need to sync between the two branches all the time (syncing from trunk-support to main isn't just merging, since there are some changes we don't want on main: the opam and dune-project file changes; the README change; possibly the new trunk support etc)
    • the cron job of the CI would work
  • downside:
    • ppxlib breaking changes would directly impact trunk CIs using ppxlib. good side: whenever we do breaking changes, we immediately send patch PRs, so in the CIs they can pin to our patch branches
    • we need to make sure we add the opam bound when cutting releases
      • we should have a simple release script

"small" caveat: we have already announced the trunk-support branch. So we need to be sure having trunk support in main is really what we want before announcing the change. Is it possible to have a branch alias (a github action pushing any change from main to trunk-support? Then, no PRs should be accepted to trunk-support anymore.

Recent work

  • documentation
    • mdx has released its support for mld-files 🎉 so, Paul-Elliot will "port" the examples in the ppxlib documentation to MDX
  • error reporting
  • stability
Clone this wiki locally