Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error msg for X-token registration #406

Merged
merged 1 commit into from Jul 20, 2021

Conversation

EmileRolley
Copy link
Collaborator

This PR fix the first point suggered by @erikmd in the issue #405.

    This fix the first point of the issue ocaml-sf#405.
@EmileRolley EmileRolley requested a review from erikmd July 20, 2021 13:05
@EmileRolley EmileRolley self-assigned this Jul 20, 2021
Copy link
Member

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge as soon as the CI terminates.

@erikmd
Copy link
Member

erikmd commented Jul 20, 2021

BTW @EmileRolley regarding GitHub assignees, if you don't disagree I'd suggest we follow the same approach as that of the Coq dev. team… which is a bit standard IINM:

  • On an issue, the assignee is the developer/maintainer that will address the issue (open a PR)
  • On a PR, the assignee is the maintainer that will merge the PR (after the approval from the reviewer(s))

@EmileRolley
Copy link
Collaborator Author

BTW @EmileRolley regarding GitHub assignees, if you don't disagree I'd suggest we follow the same approach as that of the Coq dev. team… which is a bit standard IINM:

  • On an issue, the assignee is the developer/maintainer that will address the issue (open a PR)
  • On a PR, the assignee is the maintainer that will merge the PR (after the approval from the reviewer(s))

MB, I will update this.

@EmileRolley EmileRolley assigned erikmd and unassigned EmileRolley Jul 20, 2021
@erikmd
Copy link
Member

erikmd commented Jul 20, 2021

Just a minor comment: it seems GItHub did not recognized your two e-mails as associated to your account:

2021-07-20_15-26-44_Screenshot_GH_logo

maybe because you did git commit --amend and not git commit --amend --reset-author? cf. this screenshot from gitk:

2021-07-20_15-27-40_Screenshot_emails

anyway I guess it's a very minor issue! and it might suffice for you to keep this commit as is, and add the other e-mail address here? https://github.com/settings/emails

@EmileRolley
Copy link
Collaborator Author

maybe because you did git commit --amend and not git commit --amend --reset-author?

Indeed 😅. It's fixed.

@erikmd erikmd merged commit 1b4a112 into ocaml-sf:master Jul 20, 2021
@EmileRolley EmileRolley deleted the fix-Xtoken-registration-errmsg branch July 20, 2021 14:23
@erikmd erikmd mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants