Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of exercises processing #64

Merged
merged 8 commits into from
Jul 25, 2018
Merged

Refactoring of exercises processing #64

merged 8 commits into from
Jul 25, 2018

Conversation

picdc
Copy link
Collaborator

@picdc picdc commented Jul 23, 2018

This PR refactors slightly how exercises are read and processed. It adds a proper representation for exercises, and correctly propagates the informations from meta.json.

The module Learnocaml_exercise now contains a proper representation for exercises, with its own encoding. The previous representation is still used as an intermediate state, which is still useful to store the result of reading files. As of now, the function get and set are both replaced by respectively access and decipher, and update and cipher. As their name suggest, only cipher and decipher can encode and decode files properly.

This also fixes #26

@picdc picdc mentioned this pull request Jul 23, 2018
Closed
@picdc picdc changed the title Refactoring of exercises processing WIP: Refactoring of exercises processing Jul 24, 2018
@picdc picdc changed the title WIP: Refactoring of exercises processing Refactoring of exercises processing Jul 24, 2018
@picdc
Copy link
Collaborator Author

picdc commented Jul 24, 2018

Issue #65 is now fixed, and the format is ready to support translations of the exercises descriptions.

AltGr added a commit that referenced this pull request Jul 25, 2018
@AltGr
Merge pull-request #64 from OCamlPro-Couderc/refactor-process
84895f8
This was referenced Jul 25, 2018
Closed
Closed
@picdc
Copy link
Collaborator Author

picdc commented Jul 25, 2018

The PR has not been merged entirely. The last 3 commits are missing (which makes #67 irrelevant).

@AltGr
Copy link
Collaborator

AltGr commented Jul 25, 2018

AH! Gotcha... I merged the refactor-process branch from your fork, instead of the one on ocaml-sf, which was the one the PR was made from. Fixing...

@AltGr AltGr merged commit 163b0d1 into master Jul 25, 2018
AltGr added a commit that referenced this pull request Jul 25, 2018
@AltGr
Revert "Merge pull-request #64 from OCamlPro-Couderc/refactor-process…
e49e41c 
…" (wrong branch)

This reverts commit 84895f8, reversing
changes made to 343f2a0.
AltGr added a commit that referenced this pull request Jul 25, 2018
@AltGr
Merge pull-request #64 from branch refactor-process
475b2b6
@AltGr
Copy link
Collaborator

AltGr commented Jul 25, 2018

Reverted the bogus merge, and pushed a proper one. We should finally be in sync!

@erikmd erikmd deleted the refactor-process branch September 26, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

title.txt and meta.json
2 participants
@picdc @AltGr