doesn't work with .gitconfig

[samoht]

Is that expected?

$ ledit ocaml
        OCaml version 4.01.0
# #require "toml";;
# let t = Toml.from_filename "/Users/thomas/.gitconfig";;
Exception: TomlParser.Error.

$ cat /Users/thomas/.gitconfig
[color]
    ui = true
[user]
    name = Thomas Gazagnaire
    email = thomas@gazagnaire.org
[push]
    default = simple
[core]
    editor = emacs

[samoht]

(I'm using the version in opam: 1.0.0)

[mackwic]

Hi @samoht and thanks for using To.ml.

You are right, your gitconfig is compliant with the Toml language, so it's a bug on the 1.0 parser.

As we are about to publish a complete rewrite of the parser, I have to ask you if you can upgrade to the last OCaml version or if we have to maintain a backward-compatible 1.0.

In the first case, that is: you can upgrade as you will and have no legacy, I will close this issue as it happens on old code.
In the latter case, the fix might take a little while to be published but I'm ok to do the effort.

[samoht]

Sure, feel free to change the API, I'm not using To.ml in any of my projects (yet). Thanks for the library though, it looks quite useful!

[samoht]

The git version doesn't compile with OCaml 4.01: would be nice if it could!

[mackwic]

It depend of our policy, and for now I'm not sure. For one, we can say that minor versions increment shouldn't break the compilation, but we can also take a more politic view, encourage Opam, and force the dependency on 4.02 because the OCaml world need to move on and managing versions with opam is really dumb easy.

It's really just politic at this point, and as @sagotch is the main craftsman of the 2.0, I need his opinion on this topic.

[samoht]

My point is that then you can't use To.ml in projects that works on 4.01 only (for instance mirage). I can understand that some of the 4.02 features are neat to use, but To.ml is a (relatively) simple and (potentially) very useful library which, if made portable, could be used pervasively.

[mackwic]

I agree, and the Mirage example is a strong point in favor of being 4.01-compatible.

My point is, @sagotch could have reasons to make To.ml depend on 4.02, and I wait for his input before taking any decision.

[mackwic]

discussion on this topic moved to #9 .
I close this issue