Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI jobs (and add a windows job) #134

Merged
merged 4 commits into from Jul 18, 2023
Merged

More CI jobs (and add a windows job) #134

merged 4 commits into from Jul 18, 2023

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Feb 27, 2023

In addition to the existing CI, this PR adds 3 6 more CI jobs using the ocaml-setup github action.

  • It gives more freedom regarding what version of ocaml we're testing against - this PR tests for 4.14 and 5.0
  • It enables windows in the CI (in addition to Macos and Linux)
  • It tests opam install as well

The down side is that it's slower than the existing jobs as it has to recompile the ocaml compiler everytime (modulo caches).
I kept the existing jobs as it gives faster feedback.

The second commit is necessary to have test pass on windows

The last commit 6ec3aa3 fixes the build on windows (following #135)

fix #98

@hhugo
Copy link
Contributor Author

hhugo commented Mar 3, 2023

@dra27, I've followed your advice and used gitattributes instead of changing the tests

@hhugo
Copy link
Contributor Author

hhugo commented Mar 15, 2023

I've added OCaml 5 to the CI (including windows) and fix the build on windows with 6ec3aa3 (as suggested by @dra27 )

@hhugo
Copy link
Contributor Author

hhugo commented Jun 13, 2023

@xavierleroy, do you have any opinion on this ?

@dra27, can you check the CI script regarding how to use ocaml 5 on windows ?

@xavierleroy
Copy link
Contributor

I'm a complete noob concerning Github actions, so thanks @hhugo for the CI script you proposed. I was able to fix a typo in the script, but that's about the extent of my competence here.

The script runs in about 22 minutes, which is a lot of CPU cycles for such a small library and a small test suite. On the other hand, there is not much activity on Zarith, so the script will not run very often.

Let's merge this PR and we'll see how it works in practice.

@xavierleroy xavierleroy merged commit b139389 into ocaml:master Jul 18, 2023
8 checks passed
@hhugo hhugo deleted the ci branch July 18, 2023 13:14
@hhugo
Copy link
Contributor Author

hhugo commented Jul 19, 2023

@xavierleroy, FYI, the CI tooks ~10minutes on your latest commit, probably thanks to caching.
It is still significantly longer than the original CI job but already much better than the 22minutes you've witnessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows to the CI
2 participants