Skip to content

Commit

Permalink
fix: do not impose no_sandboxing on ocamldep
Browse files Browse the repository at this point in the history
ocamlc and ocamlopt don't play well with sandboxing, but ocamldep is
fine

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: cd518774-0ed7-4f52-9169-a709ac1ab7a7
  • Loading branch information
rgrinberg committed Dec 21, 2022
1 parent f27f63e commit d752610
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ Unreleased
- Fix inline tests with *js_of_ocaml* and whole program compilation mode
enabled (#6645, @hhugo)

- Allow `--sandbox` to affect `ocamldep` invocations. Previously, they were
wrongly marked as incompatible (#.., @rgrinberg)

3.6.1 (2022-11-24)
------------------

Expand Down
2 changes: 1 addition & 1 deletion src/dune_rules/compilation_context.ml
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ let create ~super_context ~scope ~expander ~obj_dir ~modules ~flags
let opaque = eval_opaque (Super_context.context super_context) opaque in
let ocamldep_modules_data : Ocamldep.Modules_data.t =
{ dir = Obj_dir.dir obj_dir
; sandbox
; sandbox = Sandbox_config.no_special_requirements
; obj_dir
; sctx = super_context
; vimpl
Expand Down

0 comments on commit d752610

Please sign in to comment.