Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dirs ...) not recognised in dune2 #2938

Open
houndofsound opened this issue Nov 28, 2019 · 4 comments
Open

(dirs ...) not recognised in dune2 #2938

houndofsound opened this issue Nov 28, 2019 · 4 comments
Labels

Comments

@houndofsound
Copy link

I see the following when offering this line through an ocaml format dune file:

8 | (dirs *)
^^^^
Error: Unknown constructor dirs

it seems to work as expected in a static dune file though.

@bschommer
Copy link
Contributor

I had a similar issue #2711 when adding the (dir ...) in a file included via (include ...).

@ghost
Copy link

ghost commented Dec 3, 2019

This is a known limitation. We might be able to loosen this restriction in the future, but not right now. The code is not ready for that.

We could definitely improve the error message though.

@jordwalke
Copy link
Contributor

jordwalke commented Mar 16, 2020

I have also hit this problem in a different workflow. Just thought I'd mention it.
I needed to copy_files from another library that had this generated dune config:

(include_subdirs unqualified)
(dirs :standard __whitelistThisUnderscoreDir)

But I was unable to copy the files in the underscored directory, because copy_files can't see the directories whitelisted in dirs (since that part of the dune file is generated).

rgrinberg added a commit that referenced this issue Aug 19, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@polytypic
Copy link

I also hit this limitation while trying to work around another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants