Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current directory as vendored is not working #3019

Closed
Julow opened this issue Jan 9, 2020 · 3 comments · Fixed by #3056 or ocaml/opam-repository#15845
Closed

Current directory as vendored is not working #3019

Julow opened this issue Jan 9, 2020 · 3 comments · Fixed by #3056 or ocaml/opam-repository#15845
Assignees
@voodoos
Labels
bug

Comments

@Julow
Copy link
Contributor

Julow commented Jan 9, 2020

Actual Behavior

The (vendored_dirs .) stanza is not marking sub-directories as vendored.
I would expect this to work the same way as declaring the same directory as vendored from a parent directory:
(vendored_dirs sub) in root/dune vs
(vendored_dirs .) in root/sub/dune.

Reproduction

For example, using (vendored_dirs .) instead of (vendored_dirs *) in test/blackbox-tests/test-cases/vendor/duniverse/dune changes the test output.

Specifications

Using the dev version of Dune with OCaml 4.08.1.
@ghost
Copy link

ghost commented Jan 13, 2020

I agree that this is a bit confusing. At the very least dune should warn when seeing (vendored_dirs .) and hint the user to write (vendored_dirs *) instead. BTW, I would expect (vendored_dirs .) to mark the current directory as a vendored directory instead of just sub-directories.

@ghost ghost added the bug label Jan 13, 2020
@voodoos
Copy link
Collaborator

voodoos commented Jan 17, 2020 •
edited

Looks like the behavior is the same for the data_only_dirs stanza.

But I feel like, at least for data_only_dirs this is a coherent behavior: it feels ankward to add a "do not evaluate the dune files in that folder" rule in the dune file of that same folder.

@ghost
Copy link

ghost commented Jan 20, 2020

Agreed. Just emitting a warning in both cases seems good to me

@voodoos voodoos self-assigned this Jan 23, 2020
@voodoos voodoos mentioned this issue Jan 24, 2020
Merged
@rgrinberg rgrinberg mentioned this issue Feb 15, 2020
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Feb 15, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
946b24e 
…lugin, dune-private-libs and dune-glob (2.3.0)

CHANGES:

- Improve validation and error handling of arguments to `dune init` (ocaml/dune#3103, fixes
  ocaml/dune#3046, @shonfeder)

- `dune init exec NAME` now uses the `NAME` argument for private modules (ocaml/dune#3103,
  fixes ocaml/dune#3088, @shonfeder)

- Avoid linear walk to detect children, this should greatly improve
  performance when a target has a large number of dependencies (ocaml/dune#2959,
  @ejgallego, @aalekseyev, @Armael)

- [coq] Add `(boot)` option to `(coq.theories)` to enable bootstrap of
  Coq's stdlib (ocaml/dune#3096, @ejgallego)

- [coq] Deprecate `public_name` field in favour of `package` (ocaml/dune#2087, @ejgallego)

- Better error reporting for "data only" and "vendored" dirs. Using these with
  anything else than a strict subdirectory or `*` will raise an error. The
  previous behavior was to just do nothing  (ocaml/dune#3056, fixes ocaml/dune#3019, @voodoos)

- Fix bootstrap on bytecode only switches on windows or where `-j1` is set.
  (ocaml/dune#3112, @xclerc, @rgrinberg)

- Allow `enabled_if` fields in `executable(s)` stanzas (ocaml/dune#3137, fixes ocaml/dune#1690
  @voodoos)

- Do not fail if `ocamldep`, `ocamlmklib`, or `ocaml` are absent. Wait for them
  to be used to fail (ocaml/dune#3138, @rgrinberg)

- Introduce a `strict_package_deps` mode that verifies that dependencies between
  packages in the workspace are specified correctly. (@rgrinberg, ocaml/dune#3117)
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Feb 15, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
849b1a4 
…lugin, dune-private-libs and dune-glob (2.3.0)

CHANGES:

- Improve validation and error handling of arguments to `dune init` (ocaml/dune#3103, fixes
  ocaml/dune#3046, @shonfeder)

- `dune init exec NAME` now uses the `NAME` argument for private modules (ocaml/dune#3103,
  fixes ocaml/dune#3088, @shonfeder)

- Avoid linear walk to detect children, this should greatly improve
  performance when a target has a large number of dependencies (ocaml/dune#2959,
  @ejgallego, @aalekseyev, @Armael)

- [coq] Add `(boot)` option to `(coq.theories)` to enable bootstrap of
  Coq's stdlib (ocaml/dune#3096, @ejgallego)

- [coq] Deprecate `public_name` field in favour of `package` (ocaml/dune#2087, @ejgallego)

- Better error reporting for "data only" and "vendored" dirs. Using these with
  anything else than a strict subdirectory or `*` will raise an error. The
  previous behavior was to just do nothing  (ocaml/dune#3056, fixes ocaml/dune#3019, @voodoos)

- Fix bootstrap on bytecode only switches on windows or where `-j1` is set.
  (ocaml/dune#3112, @xclerc, @rgrinberg)

- Allow `enabled_if` fields in `executable(s)` stanzas (ocaml/dune#3137, fixes ocaml/dune#1690
  @voodoos)

- Do not fail if `ocamldep`, `ocamlmklib`, or `ocaml` are absent. Wait for them
  to be used to fail (ocaml/dune#3138, @rgrinberg)

- Introduce a `strict_package_deps` mode that verifies that dependencies between
  packages in the workspace are specified correctly. (@rgrinberg, ocaml/dune#3117)

- Make sure the `@all` alias is defined when no `dune` file is present
  in a directory (ocaml/dune#2946, fix ocaml/dune#2927, @diml)
mgree pushed a commit to mgree/opam-repository that referenced this issue Feb 19, 2020
@rgrinberg @mgree
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
9848870 
…lugin, dune-private-libs and dune-glob (2.3.0)

CHANGES:

- Improve validation and error handling of arguments to `dune init` (ocaml/dune#3103, fixes
  ocaml/dune#3046, @shonfeder)

- `dune init exec NAME` now uses the `NAME` argument for private modules (ocaml/dune#3103,
  fixes ocaml/dune#3088, @shonfeder)

- Avoid linear walk to detect children, this should greatly improve
  performance when a target has a large number of dependencies (ocaml/dune#2959,
  @ejgallego, @aalekseyev, @Armael)

- [coq] Add `(boot)` option to `(coq.theories)` to enable bootstrap of
  Coq's stdlib (ocaml/dune#3096, @ejgallego)

- [coq] Deprecate `public_name` field in favour of `package` (ocaml/dune#2087, @ejgallego)

- Better error reporting for "data only" and "vendored" dirs. Using these with
  anything else than a strict subdirectory or `*` will raise an error. The
  previous behavior was to just do nothing  (ocaml/dune#3056, fixes ocaml/dune#3019, @voodoos)

- Fix bootstrap on bytecode only switches on windows or where `-j1` is set.
  (ocaml/dune#3112, @xclerc, @rgrinberg)

- Allow `enabled_if` fields in `executable(s)` stanzas (ocaml/dune#3137, fixes ocaml/dune#1690
  @voodoos)

- Do not fail if `ocamldep`, `ocamlmklib`, or `ocaml` are absent. Wait for them
  to be used to fail (ocaml/dune#3138, @rgrinberg)

- Introduce a `strict_package_deps` mode that verifies that dependencies between
  packages in the workspace are specified correctly. (@rgrinberg, ocaml/dune#3117)

- Make sure the `@all` alias is defined when no `dune` file is present
  in a directory (ocaml/dune#2946, fix ocaml/dune#2927, @diml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voodoos voodoos

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@Julow @voodoos