Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue warning if internal library name is used across packages #3727

Closed
avsm opened this issue Aug 19, 2020 · 2 comments
Closed

issue warning if internal library name is used across packages #3727

avsm opened this issue Aug 19, 2020 · 2 comments
Assignees

Comments

@avsm
Copy link
Member

avsm commented Aug 19, 2020

A common failure mode when publishing to opam is that a project depends on an internal library name rather than the public one. This in turn causes a build failure when built with -p.

For example:
https://github.com/ocurrent/ocluster/pull/54/files

There doesn't seem to be a good reason to use private library names across different packages. This might be a good candidate to deprecate and warn about.

@rgrinberg rgrinberg self-assigned this Aug 19, 2020
@rgrinberg
Copy link
Member

Actually, this is just a bug. We can just easily map such names. I solved this problem for package/private libraries. I'll just extract the fix into its own PR.

rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 20, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg
Copy link
Member

Fixed by #3729

rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 21, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 24, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 26, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 28, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 28, 2020
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants