Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated alert when using ocaml syntax in dune files with ocaml 4.13~alpha2 #4830

Closed
hhugo opened this issue Jul 28, 2021 · 0 comments · Fixed by #4834 or ocaml/opam-repository#20521
Closed

deprecated alert when using ocaml syntax in dune files with ocaml 4.13~alpha2 #4830

hhugo opened this issue Jul 28, 2021 · 0 comments · Fixed by #4834 or ocaml/opam-repository#20521
Labels
bug

Comments

@hhugo
Copy link
Collaborator

hhugo commented Jul 28, 2021

dune version : 2.9.0
dune file : https://github.com/ocsigen/js_of_ocaml/blob/master/lib/lwt/graphics/dune

Alert deprecated: Toploop.directive_table
File "_build/.dune/default/lib/lwt/graphics/dune.ml", line 28, characters 14-37:
28 |   Hashtbl.add Toploop.directive_table "require"

It seems that dune.ml is generated by dune itself
@nojb nojb mentioned this issue Jul 28, 2021
Merged
@voodoos voodoos added the bug label Jul 28, 2021
@ejgallego ejgallego mentioned this issue Jan 23, 2022
Merged
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this issue Jan 23, 2022
@ejgallego
[new release] dune (2.9.2)
6a457f8 
CHANGES:

- Fix missing -linkall flag when linking library dune-sites.plugin
  ( ocaml/dune#4348, @Kakadu, @bobot, reported by @Kakadu)

- No longer reference deprecated Toploop functions when using dune files in
  OCaml syntax. (ocaml/dune#4834, fixes ocaml/dune#4830, @nojb)

- Use the stag format API to be compatible with OCaml 5.0 (ocaml/dune#5351, @emillon).

- Fix post-processing of dune-package (fix ocaml/dune#4389, @strub)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Toploop.add_directive nojb/dune
[new release] dune (2.9.2) ejgallego/opam-repository
2 participants
@hhugo @voodoos