Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with directory symlink: Unexpected file kind "S_DIR" #9873

Open
emillon opened this issue Jan 31, 2024 · 1 comment · May be fixed by #9937 or #10426
Open

Error with directory symlink: Unexpected file kind "S_DIR" #9873

emillon opened this issue Jan 31, 2024 · 1 comment · May be fixed by #9937 or #10426

Comments

@emillon
Copy link
Collaborator

emillon commented Jan 31, 2024

Hi,

When a directory target contains a directory symlink (symlink whose target is a directory), the following error happens:

  Error: Error trying to read targets after a rule was run:
  - d/b: Unexpected file kind "S_DIR" (directory)
  [1]

This can be found when building ocamlbuild through pkg rules, since its source tree contains such symlinks.

I bisected that to b1c339b in #9407 (@rleshchinskiy).

@emillon emillon added the bug label Jan 31, 2024
emillon added a commit to emillon/dune that referenced this issue Jan 31, 2024
Signed-off-by: Etienne Millon <me@emillon.org>
@emillon
Copy link
Collaborator Author

emillon commented Jan 31, 2024

Repro in #9874.

emillon added a commit that referenced this issue Feb 1, 2024
Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this issue Feb 6, 2024
Fixes ocaml#9873

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon linked a pull request Feb 6, 2024 that will close this issue
@tmattio tmattio added this to the Package Management MVP milestone Feb 23, 2024
@Leonidas-from-XIV Leonidas-from-XIV linked a pull request Apr 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants