Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkg): Test resolution of ambiguous hashes #10086

Merged

Conversation

Leonidas-from-XIV
Copy link
Collaborator

I was curious what happens and it looks like we're not picking up the branch as a branch but also not failing given the ref doesn't exist as a revision either.

Thought it was worth a repro case.

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it's worth a repro. Probably worth a bug ticket as well to document this limitation. I doubt users will ever run into this, but it's useful to keep this in mind when we re-design url's.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV merged commit b5a4f6a into ocaml:main Feb 22, 2024
27 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the commit-hash-disambiguation branch February 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants