Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkg): Extend the test to use recursive submodules #10130

Merged

Conversation

Leonidas-from-XIV
Copy link
Collaborator

An end-to-end test to make sure nested submodules work as well. In this case it is mock-repo which references a submodule packages which contains a direct package foo and another submodule bar which contains the bar package. The solver tries to find a solution for bar and succeeds.

Fixes #9377

@rgrinberg
Copy link
Member

Could you move this to a separate test case? I know it's a little more work, but it's getting hard to read everything inside opam-repository-download.t

@Leonidas-from-XIV
Copy link
Collaborator Author

Yes, that's a good point, I moved the whole submodule test to its own test.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV merged commit 466d225 into ocaml:main Feb 26, 2024
26 of 27 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the recursive-submodule-test branch February 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submodules Support
2 participants