Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: sort readdir output for reproducibility #10164

Closed
wants to merge 1 commit into from
Closed

test: sort readdir output for reproducibility #10164

wants to merge 1 commit into from

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Feb 28, 2024

No description provided.

@emillon
test: sort readdir output for reproducibility
7888725 
Signed-off-by: Etienne Millon <me@emillon.org>
Leonidas-from-XIV
Leonidas-from-XIV approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; I'm surprised it managed through CI on macOS and Linux without breaking.

@rgrinberg
Copy link
Member

Same as #10162.

@emillon
Copy link
Collaborator Author

emillon commented Feb 28, 2024

until recently it was a single file I think

@emillon
Copy link
Collaborator Author

emillon commented Feb 28, 2024

ah sorry I only looked for fetch in the PRs.

@emillon emillon closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emillon @rgrinberg @Leonidas-from-XIV