Document that Reason dialect is supported out of the box #10284
Conversation
Leonidas-from-XIV
force-pushed
the
default-dialects
branch
from
d997cbf
to
158ca89
Compare
Leonidas-from-XIV
force-pushed
the
default-dialects
branch
2 times, most recently
from
d16d3c7
to
6f17e68
Compare
| When ``(using melange)`` is enabled in the `dune-project` a third dialect is | ||
| enabled: | ||
|
|
||
| * ``rescript`` for the ReScript syntax which is used in `.res` and `.resi` | ||
| files. The formatter in this case is ``rescript_syntax``. |
There was a problem hiding this comment.
This should be specified, rescript_syntax only works in Melange v1 and it doesn't support the entire rescript language (as newer versions) in any form in dune
There was a problem hiding this comment.
As someone who is a bit out of touch with Rescript and Melange, does that mean that rescript_syntax can only be used in Melange v1 (and not v2 or v3) and even then only supports an older subset of the language?
I don't know to which extent Melange v1 + ReScript are used but this sounds like a serious restriction and makes me wonder if supporting something of progressively lower relevance as time goes on and Rescript evolves makes sense overall.
There was a problem hiding this comment.
Exactly, rescript_syntax (https://opam.ocaml.org/packages/rescript-syntax/) was a tool to help people migrate from ReScript to Melange. It's not a feature dune should keep up, since rescript-syntax isn't up-to-date with https://github.com/rescript-lang/rescript-compiler in any form.
Leonidas-from-XIV
force-pushed
the
default-dialects
branch
from
47bfa1e
to
ea3acde
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
default-dialects
branch
from
3f26c74
to
05c1dd0
Compare
Today I learned that we support Reason code out of the box with no additional configuration, which is fairly nice but doesn't appear to be documented so this PR is a suggestion to add a paragraph about that.
Its a fairly neat feature and I assume it could be used more if people were aware of how easy it is to use.
@emillon also suggested that a general howto on how to use reason in a dune project could be useful and that could be a good next step. It's fairly easy after all but if it is not documented, people won't know.