test(melange): add (emit_stdlib false) to supported melange tests
#10288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/emit-stdlib-false-for-melange-test
branch
from
fb751f2
to
b089e1f
Compare
|
This is around 15-20s faster on linux. hard to tell on macOS |
|
Do you know if there's a way to set this at the env variable level? So we can set it once and any future tests added (where we/I might forget about adding |
|
I'm not sure. I also don't know whether we'd want this to be the default in tests, but probably yes? 🤔 |
rgrinberg
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(emit_stdlib false)disables emitting all the JS targets for the melange stdlib