fix(install): do substitution for sites files #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Mar 28, 2024
anmonteiro
approved these changes
Mar 28, 2024
emillon
force-pushed
the
fix-10317
branch
2 times, most recently
from
c7f4e5a
to
e71ce62
Compare
Fixes ocaml#10317 The mistake is that the logic is actually more complex that initially thought: the "executable" status is used to determine is code signing needs to happen; but artifact substitution should happen in more cases. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Mar 29, 2024
Fixes ocaml#10317 The mistake is that the logic is actually more complex that initially thought: the "executable" status is used to determine is code signing needs to happen; but artifact substitution should happen in more cases. Signed-off-by: Etienne Millon <me@emillon.org>
This was referenced Mar 29, 2024
emillon
added a commit
that referenced
this pull request
Mar 29, 2024
* test: sites modules substitution with dune install (#10326) Repro for #10317 Signed-off-by: Etienne Millon <me@emillon.org> * fix(install): do substitution for sites files (#10327) Fixes #10317 The mistake is that the logic is actually more complex that initially thought: the "executable" status is used to determine is code signing needs to happen; but artifact substitution should happen in more cases. Signed-off-by: Etienne Millon <me@emillon.org> * Changelog Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org>
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Mar 29, 2024
CHANGES: ### Fixed - Backport ocaml/dune#10327: fix a regression in `dune install` not performing artifact substitution.
pmwhite
pushed a commit
to pmwhite/dune
that referenced
this pull request
Apr 2, 2024
Fixes ocaml#10317 The mistake is that the logic is actually more complex that initially thought: the "executable" status is used to determine is code signing needs to happen; but artifact substitution should happen in more cases. Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10317