merlin: introduce generate_merlin_rules
#10328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
jchavarri
force-pushed
the
merlin/add-generate-rules-field
branch
from
f5e5270
to
dc13809
Compare
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
|
This looks like the right approach. I think you should combine this PR with #10328. It will be easier for me to asses the final result this way and the value of all of these configuration options. It would also make it easier for me to test it. |
|
Thanks for the feedback. I incorporated these changes in #10324. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate implementation to #10325.
Instead of enabling merlin rules for all contexts, this PR applies the suggestion from #10325 (comment), by adding a
generate_merlin_rulesfield that can be used from each context to opt-in for this behavior.