[3.15] backport #10333 #10431
Merged
[3.15] backport #10333 #10431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
approved these changes
Apr 17, 2024
Leonidas-from-XIV
requested changes
Apr 17, 2024
Leonidas-from-XIV
approved these changes
Apr 17, 2024
See ocaml#10333 Signed-off-by: Etienne Millon <me@emillon.org>
…docker (ocaml#10333) * fix: sendfile() in docker Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com> * use ssize_t for return value Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com> * update test Signed-off-by: Etienne Millon <me@emillon.org> * Add changelog Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Haoxiang Fei <feihaoxiang2014@gmail.com> Signed-off-by: Haoxiang Fei <tonyfettes@tonyfettes.com> Signed-off-by: Etienne Millon <me@emillon.org> Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Co-authored-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
moyodiallo
reviewed
Apr 17, 2024
Comment on lines
+21
to
+22
|
|
||
| (3 indicates that the file size is taken modulo 2**32) |
There was a problem hiding this comment.
We forgot removing this line.
There was a problem hiding this comment.
indeed. can you remove it on main?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long_valfor sendfile() parameters to fix file copying in docker (fix: useLong_valfor sendfile() parameters to fix file copying in docker #10333)