test: fixes to version-corruption.t #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emillon
commented
Apr 30, 2024
•
emillon
commented
- refactor(test): rewrite compare.sh in ocaml. This removes the external dependencies and makes intent clearer. The count changes because it was counting the numbers of characters differing in the hexdump instead of a byte count.
- fix(test): disable version-corruption.t on mac. When codesigning triggers, the binary layout is completely changed to it's not meaningful to count the number of changed bytes.
emillon
force-pushed
the
macos-version-corruption
branch
from
8e12391
to
3175ee1
Compare
emillon
changed the title
Closed
2 tasks
This removes the external dependencies and makes intent clearer. The count changes because it was counting the numbers of characters differing in the hexdump instead of a byte count. Signed-off-by: Etienne Millon <me@emillon.org>
When codesigning triggers, the binary layout is completely changed to it's not meaningful to count the number of changed bytes Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
macos-version-corruption
branch
from
0f3d160
to
beee004
Compare
emillon
added a commit
to emillon/dune
that referenced
this pull request
May 24, 2024
* refactor(test): rewrite compare.sh in ocaml This removes the external dependencies and makes intent clearer. The count changes because it was counting the numbers of characters differing in the hexdump instead of a byte count. Signed-off-by: Etienne Millon <me@emillon.org> * fix(test): disable version-corruption.t on mac When codesigning triggers, the binary layout is completely changed to it's not meaningful to count the number of changed bytes Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
May 24, 2024
* fix(test): silence duplicate -lc++ warnings on mac (#10468) When linking C++ on recent macos versions, the linker will emit a duplicate `-lc++` warning which we can silence in the test suite. Signed-off-by: Etienne Millon <me@emillon.org> * test: fixes to version-corruption.t (#10469) * refactor(test): rewrite compare.sh in ocaml This removes the external dependencies and makes intent clearer. The count changes because it was counting the numbers of characters differing in the hexdump instead of a byte count. Signed-off-by: Etienne Millon <me@emillon.org> * fix(test): disable version-corruption.t on mac When codesigning triggers, the binary layout is completely changed to it's not meaningful to count the number of changed bytes Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org> * ci: run build on macOS x86_64 again (#10481) Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * test: fix truncate on macOS (#10361) Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org> --------- Signed-off-by: Etienne Millon <me@emillon.org> Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org> Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Co-authored-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.