Use compiler toolchains when building packages #10478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download, build, and install the necessary toolchains when building packages that depend on versions of ocaml supported by the toolchains feature. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
This prevents dune from attempting to download or build packages containing compilers whose versions are supported by dune toolchains. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
This forces the dependency solver to choose a compatible version of the ocaml compiler. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Leonidas-from-XIV
approved these changes
May 2, 2024
| @@ -733,6 +733,9 @@ let solve_lock_dir | |||
| ~pins:pinned_packages | |||
| ~constraints | |||
| = | |||
| (* Make sure that the solution contains a version of the compiler | |||
| that's compatible with dune toolchains. *) | |||
| let constraints = Toolchain.Compiler_package.constraint_ :: constraints in | |||
There was a problem hiding this comment.
Smart :-)
(However I am worried that the error message, if the user happens to run into an incompatible compiler will be impossible to understand)
There was a problem hiding this comment.
haha yep for sure, we can tidy this up before merging the toolchains branch into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change dune will use compiler toolchains when building packages rather than using a compiler from an opam package or the system. This allows dune to build projects on systems where ocaml is not installed, and avoids the relocation issues affecting the compiler package. If the necessary toolchain to build a project is not installed, dune will download, build, and install it before proceeding to build the project.