feat(melange): support lint in melange.emit
#10494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
jchavarri
approved these changes
May 14, 2024
There was a problem hiding this comment.
Why not using the "single file" approach like all other Melange tests? It seems Dune tests are moving in that direction (and imo it makes easier to understand what's going on in the tests quickly).
There was a problem hiding this comment.
I copied it from the other lint test in the codebase, and it has the same structure.
MA0010
pushed a commit
to MA0010/dune
that referenced
this pull request
Jun 5, 2024
* test(melange): parse lint but show it not working in melange.emit Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * feat(melange): support lint in `melange.emit` Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support lint in
melange.emitcloses #7353