fix(pkg): remove External_copy #10512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix_pkg___remove_external_copy
branch
from
15f08c0
to
6b075d4
Compare
This was
linked to
issues
May 10, 2024
rgrinberg
force-pushed
the
ps/rr/fix_pkg___remove_external_copy
branch
2 times, most recently
from
bd6f2ae
to
426a6a5
Compare
gridbugs
approved these changes
May 13, 2024
test/blackbox-tests/test-cases/pkg/pin-stanza/update-non-dune-local-pin.t
Outdated
Show resolved
Hide resolved
Make it the same as file://. Both of these constructors mean the same thing, so let's keep one of them. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: cc26aabc-5ed3-42c9-90db-53efae6ec9da -->
rgrinberg
force-pushed
the
ps/rr/fix_pkg___remove_external_copy
branch
from
426a6a5
to
79b7df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it the same as file://. Both of these constructors mean the same thing, so let's keep one of them. This simplification also fixes dune reacting to changes made to pinned packages.
There's still some ugliness around the types. In particular, we should be more careful about where we expect the url to point to a file vs a directory.
Note that I still haven't yet removed the separate constructors in the frontend. That's going to conflict with some PR's I have, so I will do that later.
Signed-off-by: Rudi Grinberg me@rgrinberg.com