Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: set with-dev-setup opam variable by default #10540

Merged
merged 1 commit into from
May 17, 2024

Conversation

gridbugs
Copy link
Collaborator

We missed this variable when initially implementing the solver. The opam library expects this variable to be set in the solver environment. It's rarely used so we haven't run into any issues until now.

Fixes #10538

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs gridbugs force-pushed the set-with-dev-setup-by-default branch from dfe75c2 to 516522c Compare May 17, 2024 06:03
@gridbugs gridbugs merged commit 653e203 into ocaml:main May 17, 2024
27 of 28 checks passed
@gridbugs gridbugs deleted the set-with-dev-setup-by-default branch May 17, 2024 06:46
MA0010 pushed a commit to MA0010/dune that referenced this pull request Jun 5, 2024
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg: packages that use the with-dev-setup opam variable cause dune to crash while solving
2 participants