Implicit relock if the dependencies have changed #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
reviewed
May 20, 2024
gridbugs
approved these changes
May 20, 2024
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
implicit-relock
branch
from
d4384d4
to
7ba241c
Compare
gridbugs
pushed a commit
to gridbugs/dune
that referenced
this pull request
Jun 11, 2024
* Factor out validation function Signed-off-by: Marek Kubica <marek@tarides.com> * Relock if the lock dir is out of date Signed-off-by: Marek Kubica <marek@tarides.com> --------- Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lockfiles exist and these are out of date, this PR runs the solver again to re-create the lock directory.
Obsoletes #10487 as this only does the automatic locking only if the user opted in by running
dune pkg lockbefore.