pkg: use our unpack code for rsync urls #10556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
May 22, 2024
This removes an important use of `fetch_others`. (the test was printing the expected hash instead of the computed one) Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
|
Thanks. I added some checks for this and |
MA0010
pushed a commit
to MA0010/dune
that referenced
this pull request
Jun 5, 2024
* pkg: use our unpack code for rsync urls This removes an important use of `fetch_others`. (the test was printing the expected hash instead of the computed one) Signed-off-by: Etienne Millon <me@emillon.org> * refactor: use check_checksum in the download case Signed-off-by: Etienne Millon <me@emillon.org> * Add defensive code Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an important use of
fetch_others.(the test was printing the expected hash instead of the computed one)