odoc: don't generate raw HTML and level 1 headings #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page generation code really should be moved to odoc, however.
The markup emitted by Jbuilder treated module lists as inline elements that can appear inside a line. However, neither ocamldoc nor odoc render module lists as inline elements. They are instead block elements, that are laid out vertically, like lists or paragraphs. Correspondingly, odoc now rejects inline module list markup. A side effect of the (rejected) misconception is that there was a stray period appearing on its own line in every module list generated by Jbuilder. This is now fixed.
|
The second commit fixes this as a side effect:
cc @andreas in case you spot it later, it's already reported :) |
|
Definitely. Let us know what kind of support you need from odoc to move it there. |
rgrinberg
pushed a commit
to rgrinberg/jbuilder
that referenced
this pull request
Apr 2, 2018
rgrinberg
pushed a commit
that referenced
this pull request
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page generation code really should be moved to odoc, however.